Skip to content

chore: call TransactionController handlers from BridgeStatusController#27718

Closed
micaelae wants to merge 18 commits into
mainfrom
swaps3560-submitTx-transaction-handlers
Closed

chore: call TransactionController handlers from BridgeStatusController#27718
micaelae wants to merge 18 commits into
mainfrom
swaps3560-submitTx-transaction-handlers

Conversation

@micaelae
Copy link
Copy Markdown
Member

@micaelae micaelae commented Mar 19, 2026

Description

  • Bumps the bridge-status-controller, which calls the transaction handlers directly through the messenger. This PR removes the handler functions provided to BridgeStatusController's constructor, and adds permissions for the equivalent TransactionController actions
  • Also bumps the TransactionPayController because it calls the submitTx handler

Changelog

CHANGELOG entry: chore: call TransactionController handlers from BridgeStatusController

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3560

Manual testing steps

  1. Submit a swap transaction with approval on BSC (stx)
  2. Submit a swap transaction with approval, with STX off on Polygon (7702)
  3. Submit a swap transaction with approval on Optimism (regular tx)
  4. Submit a swap transaction with approval on BSC (stx, hardware wallet)
  5. Submit a swap transaction with approval on Optimism (regular tx, hardware wallet)
  6. Submit an intent order
  7. Submit a perps quote provided by the bridge-api (not relay)
  8. Test scenarios 1-5 for bridge transactions

For each scenario, verify:

  1. Bridge status updates as expected
  2. Activity details for bridge tx is accurate
  3. No new console errors
  4. Transaction succeeds
  5. Completed event is published after success

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit 6076c1d. Configure here.

@micaelae micaelae requested review from a team as code owners March 19, 2026 23:22
@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 19, 2026
@github-actions github-actions Bot added size-S risk-high Extensive testing required · High bug introduction risk labels Mar 19, 2026
@micaelae micaelae marked this pull request as draft March 19, 2026 23:24
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@github-actions github-actions Bot added size-M and removed size-S labels Mar 19, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.35%. Comparing base (eb832ce) to head (77f9a3c).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #27718    +/-   ##
========================================
  Coverage   82.34%   82.35%            
========================================
  Files        4787     4795     +8     
  Lines      123646   123760   +114     
  Branches    27511    27540    +29     
========================================
+ Hits       101822   101923   +101     
- Misses      14779    14784     +5     
- Partials     7045     7053     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 27, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 1, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@micaelae micaelae closed this Apr 1, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-high Extensive testing required · High bug introduction risk size-M team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants